refactor: 💡 rename arialabel to aria-labelledby for key/value #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
reviewed
Dec 17, 2024
ui/admin/app/components/form/field/list-wrapper/key-value/index.hbs
Outdated
Show resolved
Hide resolved
ZedLi
approved these changes
Dec 17, 2024
lisbet-alvarez
approved these changes
Dec 17, 2024
…nput-elements-missing-accname
cameronperera
deleted the
ICU-15701-boundary-enterprise-a-11-y-audit-input-elements-missing-accname
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15701
Description
I noticed this slight naming issue while investigating one of our a11y audit issues. The main issue of no
aria-labelhas already been taking care of but the naming of the attributes was a little off. I updated it to sayaria-labelledbyto reduce confusion on what is actually be used when rendering new inputs for the key/value component.Screenshots (if appropriate)
How to Test
Checklist