Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 💍 use selectors in update credential-libraries #2624

Merged
merged 3 commits into from
Dec 12, 2024
Merged

test: 💍 use selectors in update credential-libraries #2624

merged 3 commits into from
Dec 12, 2024

Conversation

cameronperera
Copy link
Collaborator

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15467

Description

Update selectors for "update credential libraries" tests

I keep in line with recent changes by Carlos, I updated the "name is required" tests that we were using to accurately reflect a required field.

Screenshots (if appropriate)

How to Test

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Dec 11, 2024
@cameronperera cameronperera requested a review from a team as a code owner December 11, 2024 21:57
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:13pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:13pm

calcaide
calcaide approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the refactor!! 🙌

@cameronperera cameronperera merged commit 5e7b74a into main Dec 12, 2024
12 checks passed
@cameronperera cameronperera deleted the ICU-15467-credential-library-update-test branch December 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide approved these changes

Assignees

@cameronperera cameronperera

Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronperera @calcaide