Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICU-15647] Replace Rose::Dialog with Hds::Modal in admin ui only #2623

Merged
merged 25 commits into from
Dec 20, 2024
Merged

[ICU-15647] Replace Rose::Dialog with Hds::Modal in admin ui only #2623

merged 25 commits into from
Dec 20, 2024

Conversation

laurenolivia
Copy link
Collaborator

@laurenolivia laurenolivia commented Dec 11, 2024 •
edited
Loading

Description

Replace Rose::Dialog component with Hds::Modal component in admin ui.

This change caused 63 tests to fail, which have also been fixed in this PR.

🎟️ Jira ticket

Screenshots 📸

Before 👇
Screenshot 2024-12-11 at 2 05 33 PM

After 👇
Screenshot 2024-12-20 at 2 03 45 PM

Recording 📹

Screen.Recording.2024-12-11.at.2.27.17.PM.mov

How to Test

  1. Navigate to Targets
  2. Enter any text in a required field
  3. Navigate to another section in navbar to trigger modal

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@laurenolivia laurenolivia requested a review from a team as a code owner December 11, 2024 19:34
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 7:00pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 7:00pm

@laurenolivia laurenolivia changed the title Laurenolivia/replace rose dialog [ICU-15647] Replace Rose::Dialog with Hds::Modal Dec 11, 2024
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-dialog branch from 8c60413 to 6511a8a Compare December 11, 2024 19:37
@laurenolivia laurenolivia marked this pull request as draft December 11, 2024 20:08
@laurenolivia laurenolivia changed the title [ICU-15647] Replace Rose::Dialog with Hds::Modal [ICU-15647] Replace Rose::Dialog with Hds::Modal in admin ui Dec 12, 2024
@laurenolivia laurenolivia changed the title [ICU-15647] Replace Rose::Dialog with Hds::Modal in admin ui [ICU-15647] Replace Rose::Dialog with Hds::Modal in admin ui only Dec 12, 2024
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-dialog branch from 0dc5cd8 to 38dfa52 Compare December 17, 2024 15:07
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-dialog branch from d719c1e to c3e32c7 Compare December 18, 2024 15:21
@laurenolivia laurenolivia force-pushed the laurenolivia/replace-rose-dialog branch from c3e32c7 to 9fdf553 Compare December 18, 2024 15:29
ZedLi
ZedLi reviewed Dec 19, 2024
View reviewed changes
ui/admin/app/templates/application.hbs Outdated Show resolved Hide resolved
ui/admin/app/templates/application.hbs Outdated Show resolved Hide resolved
ui/admin/app/templates/application.hbs Outdated Show resolved Hide resolved
ZedLi
ZedLi approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@laurenolivia laurenolivia merged commit 422cff4 into main Dec 20, 2024
12 checks passed
@laurenolivia laurenolivia deleted the laurenolivia/replace-rose-dialog branch December 20, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide left review comments

@ZedLi ZedLi ZedLi approved these changes

Assignees
No one assigned
Labels
addons admin styles-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurenolivia @ZedLi @calcaide