Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 update @name attribute for RadioCard Groups #2617

Conversation

cameronperera
Copy link
Collaborator

@cameronperera cameronperera commented Dec 6, 2024

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15676

Description

This fixes an a11y audit issue where the name attribute for our radio card groups did not match. In a few places, the name matched the value but the name should be the same for all radio options.
I opted to simply use Type as the name value in most cases, except plugin_type which I created a new translation entry for. If we feel we need to be more specific for each resource type I can make that refactor.

Screenshots (if appropriate)

Before:
Screenshot 2024-12-06 at 4 10 22 PM
After:
Screenshot 2024-12-06 at 4 09 29 PM

How to Test

To test you can use the vercel build and create a new credential store. When you inspect the input for the Radio Cards the name attribute should be the same for both now.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Dec 6, 2024
@cameronperera cameronperera requested a review from a team as a code owner December 6, 2024 23:18
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:01pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:01pm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@cameronperera cameronperera merged commit 078e36f into main Dec 10, 2024
12 checks passed
@cameronperera cameronperera deleted the ICU-15676-boundary-enterprise-a-11-y-audit-malformed-radio-group branch December 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants