fix: 🐛 update @name attribute for RadioCard Groups #2617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15676
Description
This fixes an a11y audit issue where the
name
attribute for our radio card groups did not match. In a few places, the name matched the value but the name should be the same for all radio options.I opted to simply use
Type
as the name value in most cases, exceptplugin_type
which I created a new translation entry for. If we feel we need to be more specific for each resource type I can make that refactor.Screenshots (if appropriate)
Before:
After:
How to Test
To test you can use the vercel build and create a new credential store. When you inspect the input for the Radio Cards the
name
attribute should be the same for both now.Checklist