Icu 14778 add more sessions tests #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
commented
Dec 6, 2024
ZedLi
force-pushed
the
ICU-14778-add-more-sessions-tests
branch
from
dcccf64 to
d653798
Compare
calcaide
reviewed
Dec 6, 2024
calcaide
reviewed
Dec 6, 2024
ZedLi
force-pushed
the
ICU-14778-add-more-sessions-tests
branch
from
d653798 to
f4075fd
Compare
calcaide
approved these changes
Dec 10, 2024
cameronperera
approved these changes
Dec 10, 2024
ZedLi
force-pushed
the
ICU-14778-add-more-sessions-tests
branch
from
f4075fd to
ad95b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14778
Description
Added more session tests. Also added support for dotenv which lets us use .env files and removed usages of relative paths which makes it difficult to run if you're not in the root.
Let me know if you get any test failures, there were flaky tests at times due to sessions being canceled/terminated which can affect other test runs but it should be consistent now.
Screenshots (if appropriate)
How to Test
Run
yarn desktopin the e2e folder.Checklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description