Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icu 15713 address deprecation warning for dropdown interactive element #2561

Conversation

DhariniJeeva
Copy link
Collaborator

Description

This pr fixes the deprecation warning for the dropdown interactive element.

Note: I used codemod for some of the files, but I had to manually update the rest where the element is wrapped with a conditional statement since the codemod currently does not handle this case. ticket here for that

Screenshots (if appropriate)

How to Test

  1. click on any page that has the dropdown interactive element (auth-methods->oidc->click on change state component)
  2. open the console, you should not see the deprecation warning

Checklist

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@DhariniJeeva DhariniJeeva self-assigned this Nov 12, 2024
@DhariniJeeva DhariniJeeva requested a review from a team as a code owner November 12, 2024 21:51
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:41pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:41pm

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, thx for this big refactor!! looks good!

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!! 🙌

@DhariniJeeva DhariniJeeva merged commit 415f638 into main Nov 19, 2024
12 checks passed
@DhariniJeeva DhariniJeeva deleted the ICU-15713-address-deprecation-warning-for-dropdown-interactive-element branch November 19, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants