-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icu 15713 address deprecation warning for dropdown interactive element #2561
Icu 15713 address deprecation warning for dropdown interactive element #2561
Conversation
the commit message for your changes. Lines starting
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, thx for this big refactor!! looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!! 🙌
…opdown-interactive-element
Description
This pr fixes the deprecation warning for the dropdown interactive element.
Note: I used codemod for some of the files, but I had to manually update the rest where the element is wrapped with a conditional statement since the codemod currently does not handle this case. ticket here for that
Screenshots (if appropriate)
How to Test
Checklist
[ ] I have added before and after screenshots for UI changes[ ] I have added JSON response output for API changes[ ] I have commented on my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature works