Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-13883 add remove org modal #2435

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Aug 12, 2024

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-13883

Description

Add a modal for when a user deselects a singular org with projects.
Add a separate modal for when a user deselects all and orgs have projects attached to them.

Screenshots (if appropriate)

Screen.Recording.2024-08-12.at.9.52.41.AM.mov

How to Test

  1. Make sure you have an org created that has various projects
  2. Go to roles page -> click on a role
  3. Click "manage" dropdown -> "manage scopes" -> "manage custom scopes"
  4. For the Org with many projects click the link under "Projects selected"
  5. Select and save a couple projects.
  6. After saving, you should now be on the "manage custom scopes" page again.
  7. If you deselect the org with projects then the modal should appear.
  8. click "Remove org and projects" and now project count should be zero
  9. Click "save" and scopes tab table should not have those projects

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:54pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:54pm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants