fix: 🐛 Fix electron not inheriting path variable in production #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DhariniJeeva
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out electron does not properly inherit the path variable from process.env.PATH in production. This presents a problem as users won't have access to many of their binaries that they normally would have on their path.
If you're wondering why I didn't use the
fix-pathpackage directly, it's because they switched over to ESM and we can't directly use it. Their previous version doesn't fix linux so I had to manually use it.Screenshots (if appropriate):
Before:
After:
How to Test
Create a production build locally and confirm your path gets loaded correctly when opening a shell in boundary.