-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade addons/auth to Ember 4.12 #1947
Merged
dvonanderson
merged 5 commits into
main
from
ICU-11332-upgrade-auth-addon-to-ember-4-12
Oct 11, 2023
Merged
Upgrade addons/auth to Ember 4.12 #1947
dvonanderson
merged 5 commits into
main
from
ICU-11332-upgrade-auth-addon-to-ember-4-12
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
reviewed
Oct 10, 2023
Refactor `.eslintrc.js` to current `ecmaVersion` and use latest `babelOptions`. Revert `.prettier.js` to use previous overrides. Setup scripts to use `concurrently` instead of `npm-run-all`
Removed `npm-run-all` from package.json
calcaide
approved these changes
Oct 11, 2023
cameronperera
approved these changes
Oct 11, 2023
ZedLi
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think just can just be merged into main now instead of a llb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
Description
Ember
addon/auth
upgrade v4.4.1...v4.12.2Checklist:
- [ ] I have added before and after screenshots for UI changes- [ ] I have added JSON response output for API changes- [ ] I have added steps to reproduce and test for bug fixes in the description- [ ] I have commented on my code, particularly in hard-to-understand areas- [ ] I have added tests that prove my fix is effective or that my feature works