Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade addons/auth to Ember 4.12 #1947

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

dvonanderson
Copy link
Contributor

🎟️ Jira ticket

Description

Ember addon/auth upgrade v4.4.1...v4.12.2

Checklist:

- [ ] I have added before and after screenshots for UI changes
- [ ] I have added JSON response output for API changes
- [ ] I have added steps to reproduce and test for bug fixes in the description
- [ ] I have commented on my code, particularly in hard-to-understand areas

  • My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:05pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:05pm

addons/auth/.eslintrc.js Outdated Show resolved Hide resolved
addons/auth/.prettierrc.js Outdated Show resolved Hide resolved
addons/auth/package.json Outdated Show resolved Hide resolved
dvonanderson added 2 commits October 10, 2023 13:56
Refactor `.eslintrc.js` to current `ecmaVersion` and use latest
`babelOptions`. Revert `.prettier.js` to use previous overrides. Setup
scripts to use `concurrently` instead of `npm-run-all`
Removed `npm-run-all` from package.json
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think just can just be merged into main now instead of a llb

@dvonanderson dvonanderson changed the base branch from ember-upgrade-to-4.12-llb to main October 11, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants