fix: 🐛 Fix an issue with HDS css causing scrollbars/whitespace #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Closes: ICU-11292
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cameronperera
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: ICU-11292
🎟️ Jira ticket
Description
There seems to be a bug causing extra whitespace/scrollbars when an accessible class is applied in conjunction with icon only badges in HDS. I'm adding a temporary hack to remove the CSS that's causing it.
Not sure if this is the best approach, open to other ideas or possibly using rose icons again?
Screenshots (if appropriate):
Before:
After:
How to Test
Create some sessions in desktop client and make the window small enough so the table is larger than the viewport. It should not have two scrollbars with whitespace at the bottom.
Checklist:
[ ] I have added JSON response output for API changes[ ] I have added tests that prove my fix is effective or that my feature works