fix: 🐛 dynamic storage bucket showing as static #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
approved these changes
Sep 28, 2023
cameronperera
deleted the
fix/storage-bucket-dynamic-cred-showing-static
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
Description
Fixes the issue where storage buckets that use dynamic credentials are showing up as static after creation and reloading the screen.
Screenshots (if appropriate):
Before:
After:
How to Test
Need to setup a worker running in aws to test this. I will be testing this against a real boundary instance but wanted to get the PR ready.
Checklist:
I have added JSON response output for API changesI have commented on my code, particularly in hard-to-understand areas