fix: 🐛 Fix polyfill not working correctly #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Closes: ICU-11211
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
deleted the
ICU-11211-unable-to-create-resources-due-to-random-uuid-is-not-a-function-error
branch
calcaide
reviewed
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: ICU-11211
🎟️ Jira ticket
Description
The main fix was in this PR to add a polyfill. However, it wasn't correctly getting activated because we didn't have the right dependencies.
Screenshots (if appropriate):
Before:
After:
How to Test
I tested this by running against boundary dev with a local build running and setting up ngrok to deliver an http only tunnel (no TLS) to confirm that we are getting a crypto.randomUUID() error when trying to create a new resource.
Checklist:
I have added before and after screenshots for UI changesI have added JSON response output for API changesI have commented on my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature works