Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore icu 9086 audit resolutions #1928

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Conversation

calcaide
Copy link
Collaborator

@calcaide calcaide commented Sep 27, 2023

DO NOT MERGE UNTIL 0.14 release.
🎟️ Jira ticket

Description

Terser

  • After running yarn why terser is used by different deps.
  • After deleting terser from resolutions, we resolve terser@4.8.1 and terser@5.20.0 which have no security vulnerabilities as per snyk information.

jpeg-js

  • After running yarn why jpeg-js is used by playwright.
  • After deleting jpeg-js from resoltuions, we keep resolving jpeg-js@0.4.4 which have no security

How to Test

  • Build & run successfully Admin and Desktop UI.
  • Run boundary-ui-release successfully.

Checklist:

  • [ ] I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@calcaide calcaide added the dependencies Pull requests that update a dependency file label Sep 27, 2023
@calcaide calcaide self-assigned this Sep 27, 2023
@calcaide calcaide requested a review from a team as a code owner September 27, 2023 11:17
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:47am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 9:47am

Base automatically changed from chore-ICU-9085-audit-resolutions to main October 11, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants