Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix not calling delete properly in OIDC #1921

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

ZedLi
Copy link
Collaborator

@ZedLi ZedLi commented Sep 25, 2023

Description

It seems like we weren't properly calling the DELETE route for the tokens in OIDC authentications.

Screenshots (if appropriate):

Before:
image

After:
image

How to Test

Use boundary dev and test that that the tokens in boundary are deleted (by listing the tokens) after signing out.

Checklist:

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@ZedLi ZedLi requested a review from a team as a code owner September 25, 2023 22:49
@ZedLi ZedLi self-assigned this Sep 25, 2023
@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview Sep 25, 2023 10:49pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview Sep 25, 2023 10:49pm

@ZedLi ZedLi changed the title fix: 🐛 Fix not calling logout properly in OIDC fix: 🐛 Fix not calling delete properly in OIDC Sep 26, 2023
@ZedLi ZedLi merged commit 16f8b6d into main Sep 26, 2023
@ZedLi ZedLi deleted the bugfix/fix-oidc-logout branch September 26, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants