Skip to content

Commit

Permalink
refactor: 💡 rename arialabel to aria-labelledby for key/value
Browse files Browse the repository at this point in the history
  • Loading branch information
cameronperera committed Dec 17, 2024
1 parent af8655e commit 23810ef
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
24 changes: 12 additions & 12 deletions ui/admin/app/components/form/field/list-wrapper/key-value/index.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=option.key
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
setContext=(set-from-event option 'key')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=option.key
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
setContext=(set-from-event option 'key')
width=@width
)
Expand All @@ -58,14 +58,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=option.value
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
setContext=(set-from-event option 'value')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=option.value
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
width=@width
setContext=(set-from-event option 'value')
)
Expand Down Expand Up @@ -99,14 +99,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=this.newOptionKey
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
setContext=(set-from-event this 'newOptionKey')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=this.newOptionKey
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
width=@width
setContext=(set-from-event this 'newOptionKey')
)
Expand All @@ -121,14 +121,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=this.newOptionKey
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
setContext=(set-from-event this 'newOptionKey')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=this.newOptionKey
ariaLabel=keyHeaderID
aria-labelledby=keyHeaderID
width=@width
setContext=(set-from-event this 'newOptionKey')
)
Expand All @@ -146,14 +146,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=this.newOptionValue
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
setContext=(set-from-event this 'newOptionValue')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=this.newOptionValue
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
width=@width
setContext=(set-from-event this 'newOptionValue')
)
Expand All @@ -168,14 +168,14 @@
'form/field/list-wrapper/key-value/text'
disabled=@disabled
value=this.newOptionValue
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
setContext=(set-from-event this 'newOptionValue')
)
select=(component
'form/field/list-wrapper/key-value/select'
disabled=@disabled
value=this.newOptionValue
ariaLabel=valueHeaderID
aria-labelledby=valueHeaderID
width=@width
setContext=(set-from-event this 'newOptionValue')
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@value={{@value}}
@width={{@width}}
disabled={{@disabled}}
aria-labelledby={{@ariaLabel}}
aria-labelledby={{@aria-labelledby}}
{{on 'change' @setContext}}
as |F|
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
<Hds::Form::TextInput::Field
@value={{@value}}
disabled={{@disabled}}
aria-labelledby={{@ariaLabel}}
aria-labelledby={{@aria-labelledby}}
{{on 'input' @setContext}}
/>

0 comments on commit 23810ef

Please sign in to comment.