awsbase: Add unit testing for session code base #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change splits out the httptest.Server creation from the GetMockedAwsApiSession function so that the test server can be used for mocking other API responses. Tests before change ``` > go test ./... ok github.com/hashicorp/aws-sdk-go-base 1.814s ``` Tests after change ``` > go test ./... ok github.com/hashicorp/aws-sdk-go-base 1.575s ```
|
|
nywilken
commented
Aug 2, 2019
session.go
Outdated
| @@ -33,40 +33,7 @@ func GetSessionOptions(c *Config) (*session.Options, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| // Call Get to check for credential provider. If nothing found, we'll get an | |||
There was a problem hiding this comment.
Looking through the chain of events there appears to be an error check for the "NoCredentialProviders" error within the call to GetCredentials which then gets bubbled up here. So I removed this call for now and validated that with the current testing in place nothing breaks. This still needs some additional validation 🤷♂️
nywilken
commented
Aug 2, 2019
session.go
Outdated
|
|
||
| if err == nil { | ||
| return sess, accountID, partition, nil | ||
| if err != nil { |
There was a problem hiding this comment.
Happy path - return if there is an error. Otherwise continue happily down the path of normal execution.
nywilken
commented
Aug 2, 2019
session_test.go
Outdated
| t.Fatalf("GetSessionOptions(c) resulted in an error %s", err) | ||
| } | ||
|
|
||
| if opts == nil && tc.hasError == false { |
There was a problem hiding this comment.
Open question: What is the best way to validate the returned session?
nywilken
force-pushed
the
td-awsbase-package-testing
branch
from
99ecdfb
to
dcb8992
Compare
aeschright
force-pushed
the
td-awsbase-package-testing
branch
from
75e7341
to
f305c19
Compare
…ls flow Add -v to CI test run for better debugging
Rename AWS metadata 'endpoint' for clarity
aeschright
force-pushed
the
td-awsbase-package-testing
branch
from
f305c19
to
86893be
Compare
nywilken
commented
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes within this branch are a fast past at extending the testing with the awsbase pkg. In its present state it adds some basic checks for the GetSession* logic using some of the existing AWS mocks. During this exercise I've started work in looking through the tests and code structure to determine how authentication is flowing. While looking for any special edge cases or chaining that is occurring to better understand the coverage of the authentication testing already in place. This PR is merely a starting step, and anyone reviewing this code is welcome to provide feedback, improvement suggestions.
Relates #4
Relates #5
Relates #7
Goals:
make lint && make test)