V2: Linting cleanup #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdavison
force-pushed
the
v2-linting-cleanup
branch
from
23637c2
to
13e99e1
Compare
gdavison
force-pushed
the
v2-linting-cleanup
branch
from
7df6125
to
04a2629
Compare
ewbankkit
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
LGTM 🚀.
% make tools
cd tools && go install github.com/golangci/golangci-lint/cmd/golangci-lint
cd tools && go install github.com/pavius/impi/cmd/impi
% make lint
% semgrep --config .semgrep --no-rewrite-rule-ids
running 2 rules...
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|2/2
ran 2 rules on 20 files: 0 findings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tools directory for tool versioning. Updates golangci-lint rules and resolves errors