Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation with AWS SDK for Go v2 #64

Merged
merged 12 commits into from
Aug 31, 2021
Merged

Initial implementation with AWS SDK for Go v2 #64

merged 12 commits into from
Aug 31, 2021

Conversation

gdavison
Copy link
Contributor

Initial work on using AWS SDK for Go v2 instead of v1.

Authentication is incomplete:

  • EC2 instance metadata does not work
  • Setting AWS_PROFILE with default shared credentials file does not work
  • Directly setting AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY does work

Note: when using this module, you will need to add the following to your go.mod file:

replace github.com/aws/aws-sdk-go-v2/credentials => github.com/gdavison/aws-sdk-go-v2/credentials v1.2.2-0.20210811194025-146c1ad6c3b2

@gdavison gdavison requested a review from a team as a code owner August 12, 2021 22:28
@gdavison
Copy link
Contributor Author

Hmm, cannot reproduce the go mod check failure

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make test
go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go-v2 v1.8.0
go: downloading github.com/aws/aws-sdk-go-v2/config v1.6.0
go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.4.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sts v1.6.1
go: downloading github.com/gdavison/aws-sdk-go-v2/credentials v1.2.2-0.20210811194025-146c1ad6c3b2
go: downloading github.com/aws/smithy-go v1.7.0
go: downloading github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.2.2
go: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.2.0
go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.3.2
ok  	github.com/hashicorp/aws-sdk-go-base	0.864s
?   	github.com/hashicorp/aws-sdk-go-base/awsmocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/awsv1shim	9.499s
ok  	github.com/hashicorp/aws-sdk-go-base/tfawserr	2.287s

I have no go.mod conflicts either.

@gdavison gdavison merged commit 35d00ec into v2 Aug 31, 2021
@gdavison gdavison deleted the aws-sdk-go-v2 branch August 31, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants