Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and export constants to simplify mock handling, additional assume role testing #45

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #39
Reference: hashicorp/terraform#25134

The first commit is geared towards simplifying the mock handling for GetSession() testing, to allow downstream codebases to reuse the framework. The second commit, the much more interesting one, backfills assume role testing for policy, policy ARNs, tags, and transitive tag keys that was initially implemented as part of verifying the S3 Backend implementation of those configurations.

Allows downstream codebases to reuse the mocking framework.
@bflad bflad added the tests label Jun 15, 2020
@bflad bflad requested a review from a team as a code owner June 15, 2020 18:25
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added this to the v0.6.0 milestone Jul 7, 2020
@bflad bflad merged commit cc3a73c into master Jul 7, 2020
@bflad bflad deleted the t-AssumeRole branch July 7, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants