Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always enable AWS shared configuration file support #38

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Always enable AWS shared configuration file support #38

merged 1 commit into from
Jun 3, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #35

Enabling AWS shared configuration file support will no longer require the AWS_SDK_LOAD_CONFIG environment variable. 🎉

@bflad bflad added the enhancement New feature or request label Jun 2, 2020
@bflad bflad added this to the v0.5.0 milestone Jun 2, 2020
@bflad bflad requested a review from a team June 2, 2020 20:36
anGie44
anGie44 approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 LGTM @bflad !

@bflad bflad merged commit 481cea2 into master Jun 3, 2020
@bflad bflad deleted the f-SharedConfigEnable branch June 3, 2020 17:37
bflad added a commit that referenced this pull request Jun 3, 2020
@bflad
Update CHANGELOG for #38
be45422
@spenczar spenczar mentioned this pull request Jul 2, 2020
Closed
jtdoepke added a commit to jtdoepke/kubergrunt that referenced this pull request Apr 27, 2021
@jtdoepke
Always enable AWS shared configuration file support
82d1e01 
Similar to what Hashicorp has done in Terraform
(hashicorp/aws-sdk-go-base#38), always enable
AWS shared configuration file support. This way the
`AWS_SDK_LOAD_CONFIG` env var no longer needs to be set.
@jtdoepke jtdoepke mentioned this pull request Apr 27, 2021
Merged
yorinasub17 pushed a commit to gruntwork-io/kubergrunt that referenced this pull request May 3, 2021
@jtdoepke
Always enable AWS shared configuration file support (#123)
b4fb108 
Similar to what Hashicorp has done in Terraform
(hashicorp/aws-sdk-go-base#38), always enable
AWS shared configuration file support. This way the
`AWS_SDK_LOAD_CONFIG` env var no longer needs to be set.
@phillbaker phillbaker mentioned this pull request Jul 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Always Enable Shared Configuration File Support
2 participants
@bflad @anGie44