Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Issue and Pull Request Templates #26

Merged
merged 1 commit into from
May 29, 2020
Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 29, 2020

Will fix the TravisCI issue separately (and move this repository to GitHub Actions):

$ make tools
GO111MODULE=off go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
# github.com/golangci/golangci-lint/pkg/golinters
../../golangci/golangci-lint/pkg/golinters/golint.go:21:14: l.LintPkg undefined (type *"github.com/golangci/lint-1".Linter has no field or method LintPkg)
../../golangci/golangci-lint/pkg/golinters/gomnd.go:13:6: cannot use magic_numbers.Analyzer (type *"github.com/tommy-muehle/go-mnd/vendor/golang.org/x/tools/go/analysis".Analyzer) as type *"golang.org/x/tools/go/analysis".Analyzer in array or slice literal
../../golangci/golangci-lint/pkg/golinters/unused.go:16:7: undefined: unused.NewChecker
GNUmakefile:15: recipe for target 'tools' failed
make: *** [tools] Error 2
The command "make tools" failed and exited with 2 during .

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v0.6.0 milestone May 29, 2020
@bflad bflad merged commit c9611c3 into master May 29, 2020
@bflad bflad deleted the f-issue-templates branch May 29, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants