Add credentials adapter from v2 to v1 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YakDriver
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Wow 🎉
% make test
go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2 1.661s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/expand 0.452s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/test [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 1.170s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr (cached)
ewbankkit
reviewed
Feb 18, 2022
v2/awsv1shim/credentials.go
Outdated
| return p.RetrieveWithContext(context.Background()) | ||
| } | ||
|
|
||
| func (p *v2CredentialsProvider) getCreds() *awsv2.Credentials { |
There was a problem hiding this comment.
Pedantic: Rename to getCredentials().
There was a problem hiding this comment.
Or better yet, credentials()
There's nothing wrong with providing getters and setters yourself, and it's often appropriate to do so, but it's neither idiomatic nor necessary to put Get into the getter's name. If you have a field called owner (lower case, unexported), the getter method should be called Owner (upper case, exported), not GetOwner.
There was a problem hiding this comment.
Yeah, that was copied from inspired by the AWS SDK, so full of Java-isms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds and adapter between the AWS SDK for Go v2 and v1 credentials models. The previous approach did not work for credentials with an expiry.
Relates hashicorp/terraform-provider-aws#23176