Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable retry.BackoffDelayer #1045

Merged
merged 4 commits into from
May 9, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 9, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1044.

Adds the Backoff field to the Config structure to allow a configurable backoff strategy.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	6.593s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	1.001s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	0.815s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	1.127s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	1.346s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	1.443s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	1.197s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	1.233s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	1.291s

@ewbankkit ewbankkit requested a review from a team as a code owner May 9, 2024 16:00
@gdavison gdavison self-assigned this May 9, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@ewbankkit ewbankkit merged commit f532d35 into main May 9, 2024
12 checks passed
@ewbankkit ewbankkit deleted the f-configurable-retry.BackoffDelayer branch May 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configurable retry.BackoffDelayer
2 participants