fix: flag check of node logs command and incorrect download source

src/commands/node/configs.ts

@@ -238,7 +238,8 @@ export const logsConfigBuilder = function (argv, ctx, task) {
     /** @type {{namespace: string, nodeAliases: NodeAliases}} */
     const config = {
         namespace: this.configManager.getFlag(flags.namespace),
-        nodeAliases: helpers.parseNodeAliases(this.configManager.getFlag(flags.nodeAliasesUnparsed))
+        nodeAliases: helpers.parseNodeAliases(this.configManager.getFlag(flags.nodeAliasesUnparsed)),
+        nodeAliasesUnparsed: this.configManager.getFlag(flags.nodeAliasesUnparsed)
     }
     ctx.config = config
     return config

src/commands/node/flags.ts

@@ -179,7 +179,7 @@ export const ADD_EXECUTE_FLAGS = {
 }
 
 export const LOGS_FLAGS = {
-    requiredFlags: [flags.nodeAliasesUnparsed],
+    requiredFlags: [flags.namespace, flags.nodeAliasesUnparsed],
     requiredFlagsWithDisabledPrompt: [],
     optionalFlags: []
 }

src/core/helpers.ts

@@ -206,7 +206,7 @@ async function getNodeLog (pod: V1Pod, namespace: string, timeString: string, k8
     await k8.copyTo(podName, ROOT_CONTAINER, sourcePath, `${HEDERA_HAPI_PATH}`)
     await k8.execContainer(podName, ROOT_CONTAINER, `chmod 0755 ${HEDERA_HAPI_PATH}/${scriptName}`)
     await k8.execContainer(podName, ROOT_CONTAINER, `${HEDERA_HAPI_PATH}/${scriptName}`)
-    await k8.copyFrom(podName, ROOT_CONTAINER, `${HEDERA_HAPI_PATH}/${podName}.zip`, targetDir)
+    await k8.copyFrom(podName, ROOT_CONTAINER, `${HEDERA_HAPI_PATH}/data/${podName}.zip`, targetDir)
   } catch (e: Error | any) {
     // not throw error here, so we can continue to finish downloading logs from other pods
     // and also delete namespace in the end

test/test_util.ts

@@ -52,7 +52,7 @@
   AccountCreateTransaction, Hbar, HbarUnit,
   PrivateKey
 } from '@hashgraph/sdk'
-import { MINUTES, ROOT_CONTAINER, SECONDS } from '../src/core/constants.ts'
+import { MINUTES, ROOT_CONTAINER, SECONDS, SOLO_LOGS_DIR } from '../src/core/constants.ts'
 import crypto from 'crypto'
 import { AccountCommand } from '../src/commands/account.ts'
 import { SoloError } from '../src/core/errors.ts'
@@ -292,6 +292,20 @@
             expect.fail()
           }
         }).timeout(30 * MINUTES)
+
+        it('node log command should work', async () => {
+          try {
+            await expect(nodeCmd.handlers.logs(argv)).to.eventually.be.ok
+
+            const soloLogPath = path.join(SOLO_LOGS_DIR, 'solo.log')
+            const soloLog = fs.readFileSync(soloLogPath, 'utf8')
+
+            expect(soloLog).to.not.contain('failed to download logs')
+          } catch (e) {
+            nodeCmd.logger.showUserError(e)
+            expect.fail()
+          }
+        }).timeout(30 * MINUTES)
       }
     })