Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change mirror node and explorer from subchart to individual chart #743

Merged
merged 27 commits into from
Oct 31, 2024

Merge commit '7417384f2e3cf152e184ab8286914def418a3b22' into 00617-D-…

7144b1b
Select commit
Loading
Failed to load commit list.
Merged

feat: change mirror node and explorer from subchart to individual chart #743

Merge commit '7417384f2e3cf152e184ab8286914def418a3b22' into 00617-D-…
7144b1b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

87.29% (+0.20%) compared to b66fe05

View this Pull Request on Codecov

87.29% (+0.20%) compared to b66fe05

Details

Codecov Report

Attention: Patch coverage is 82.11382% with 22 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (b66fe05) to head (7144b1b).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 77.04% 12 Missing and 2 partials ⚠️
src/commands/prompts.ts 40.00% 6 Missing ⚠️
src/core/profile_manager.ts 92.85% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   87.09%   87.29%   +0.20%     
==========================================
  Files          40       42       +2     
  Lines       12545    13116     +571     
  Branches      944     1026      +82     
==========================================
+ Hits        10926    11450     +524     
- Misses       1568     1612      +44     
- Partials       51       54       +3     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.50% <100.00%> (+<0.01%) ⬆️
src/commands/network.ts 76.59% <ø> (+0.17%) ⬆️
src/core/constants.ts 96.42% <100.00%> (+0.27%) ⬆️
version.ts 100.00% <100.00%> (ø)
src/core/profile_manager.ts 94.63% <92.85%> (-0.64%) ⬇️
src/commands/prompts.ts 64.49% <40.00%> (-0.52%) ⬇️
src/commands/mirror_node.ts 76.82% <77.04%> (-0.70%) ⬇️

... and 12 files with indirect coverage changes

Impacted file tree graph