Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused keytool #669

Merged
merged 4 commits into from
Oct 10, 2024
Merged

chore: remove unused keytool #669

merged 4 commits into from
Oct 10, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • remove unused keytool

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners October 10, 2024 15:51
@JeffreyDallas JeffreyDallas self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (65a1b53) to head (866e6fd).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node.mjs 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   69.15%   68.75%   -0.41%     
==========================================
  Files          40       38       -2     
  Lines       14560    14237     -323     
  Branches      779      671     -108     
==========================================
- Hits        10069     9788     -281     
  Misses       4444     4444              
+ Partials       47        5      -42     
Files with missing lines Coverage Δ
src/core/constants.mjs 96.17% <ø> (-0.03%) ⬇️
src/core/dependency_managers/index.mjs 100.00% <100.00%> (ø)
src/core/index.mjs 100.00% <ø> (ø)
src/core/key_manager.mjs 85.14% <100.00%> (-0.03%) ⬇️
src/core/templates.mjs 91.51% <ø> (-0.18%) ⬇️
src/commands/node.mjs 38.38% <66.66%> (-0.04%) ⬇️

... and 5 files with indirect coverage changes

Impacted file tree graph

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Test Results - Linux

  1 files  ± 0   40 suites   - 5   7s ⏱️ ±0s
112 tests  - 18  112 ✅  - 18  0 💤 ±0  0 ❌ ±0 
124 runs   - 18  124 ✅  - 18  0 💤 ±0  0 ❌ ±0 

Results for commit 866e6fd. ± Comparison against base commit 65a1b53.

This pull request removes 18 tests.
should be able to check when keytool is installed ‑ KeytoolDependencyManager should be able to check when keytool is installed
should be able to check when keytool not installed ‑ KeytoolDependencyManager should be able to check when keytool not installed
should run keytool -certreq ‑ Keytool Keytool tests on darwin should run keytool -certreq
should run keytool -certreq ‑ Keytool Keytool tests on linux should run keytool -certreq
should run keytool -certreq ‑ Keytool Keytool tests on windows should run keytool -certreq
should run keytool -exportcert ‑ Keytool Keytool tests on darwin should run keytool -exportcert
should run keytool -exportcert ‑ Keytool Keytool tests on linux should run keytool -exportcert
should run keytool -exportcert ‑ Keytool Keytool tests on windows should run keytool -exportcert
should run keytool -gencert ‑ Keytool Keytool tests on darwin should run keytool -gencert
should run keytool -gencert ‑ Keytool Keytool tests on linux should run keytool -gencert
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Test Results - Windows

  1 files  ± 0   40 suites   - 5   20s ⏱️ -2s
112 tests  - 18  112 ✅  - 18  0 💤 ±0  0 ❌ ±0 
124 runs   - 18  124 ✅  - 18  0 💤 ±0  0 ❌ ±0 

Results for commit 866e6fd. ± Comparison against base commit 65a1b53.

This pull request removes 18 tests.
should be able to check when keytool is installed ‑ KeytoolDependencyManager should be able to check when keytool is installed
should be able to check when keytool not installed ‑ KeytoolDependencyManager should be able to check when keytool not installed
should run keytool -certreq ‑ Keytool Keytool tests on darwin should run keytool -certreq
should run keytool -certreq ‑ Keytool Keytool tests on linux should run keytool -certreq
should run keytool -certreq ‑ Keytool Keytool tests on windows should run keytool -certreq
should run keytool -exportcert ‑ Keytool Keytool tests on darwin should run keytool -exportcert
should run keytool -exportcert ‑ Keytool Keytool tests on linux should run keytool -exportcert
should run keytool -exportcert ‑ Keytool Keytool tests on windows should run keytool -exportcert
should run keytool -gencert ‑ Keytool Keytool tests on darwin should run keytool -gencert
should run keytool -gencert ‑ Keytool Keytool tests on linux should run keytool -gencert
…

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Oct 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.41% (target: -1.00%) 80.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (65a1b53) 14535 10186 70.08%
Head commit (866e6fd) 14237 (-298) 9919 (-267) 69.67% (-0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#669) 5 4 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

jeromy-cannon
jeromy-cannon previously approved these changes Oct 10, 2024
…rm-keytool

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	test/e2e/core/dependency_managers/keytool_dependency_manager.test.mjs
#	test/unit/commands/node.test.mjs
#	test/unit/core/dependency_managers/keytool_dependency_manager.test.mjs
#	test/unit/core/keytool.test.mjs
Copy link
Contributor

E2E Test Report

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 866e6fd. ± Comparison against base commit 65a1b53.

Copy link
Contributor

E2E Test Report

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 866e6fd. ± Comparison against base commit 65a1b53.

@jeromy-cannon jeromy-cannon merged commit c81b3b4 into main Oct 10, 2024
39 of 40 checks passed
@jeromy-cannon jeromy-cannon deleted the 00660-D-rm-keytool branch October 10, 2024 18:43
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Keytool and references in Solo
3 participants