-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused keytool #669
Conversation
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 69.15% 68.75% -0.41%
==========================================
Files 40 38 -2
Lines 14560 14237 -323
Branches 779 671 -108
==========================================
- Hits 10069 9788 -281
Misses 4444 4444
+ Partials 47 5 -42
|
Unit Test Results - Linux 1 files ± 0 40 suites - 5 7s ⏱️ ±0s Results for commit 866e6fd. ± Comparison against base commit 65a1b53. This pull request removes 18 tests.
♻️ This comment has been updated with latest results. |
Unit Test Results - Windows 1 files ± 0 40 suites - 5 20s ⏱️ -2s Results for commit 866e6fd. ± Comparison against base commit 65a1b53. This pull request removes 18 tests.
♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
…rm-keytool Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # test/e2e/core/dependency_managers/keytool_dependency_manager.test.mjs # test/unit/commands/node.test.mjs # test/unit/core/dependency_managers/keytool_dependency_manager.test.mjs # test/unit/core/keytool.test.mjs
🎉 This PR is included in version 0.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 0.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This pull request changes the following:
Related Issues