New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Connect to multicluster deployments and validate remoteConfigs #1141

Merged

jeromy-cannon merged 10 commits into main from 00913-implement-solo-cluster-connect-connects-to-a-deployment-and-pulls-back-the-remoteconfig-for-two-cluster-deployment

Jan 16, 2025

Merged

feat: Connect to multicluster deployments and validate remoteConfigs #1141

nit: fix typo

Codecov / codecov/patch failed Jan 16, 2025 in 1s

72.91% of diff hit (target 83.00%)

View this Pull Request on Codecov

72.91% of diff hit (target 83.00%)

Annotations

Check warning on line 260 in src/commands/base.ts

codecov / codecov/patch

src/commands/base.ts#L257-L260

Added lines #L257 - L260 were not covered by tests

Check warning on line 46 in src/commands/cluster/handlers.ts

codecov / codecov/patch

src/commands/cluster/handlers.ts#L46

Added line #L46 was not covered by tests

Check warning on line 50 in src/commands/cluster/handlers.ts

codecov / codecov/patch

src/commands/cluster/handlers.ts#L50

Added line #L50 was not covered by tests

Check warning on line 56 in src/commands/cluster/tasks.ts

codecov / codecov/patch

src/commands/cluster/tasks.ts#L56

Added line #L56 was not covered by tests

Check warning on line 147 in src/commands/cluster/tasks.ts

codecov / codecov/patch

src/commands/cluster/tasks.ts#L145-L147

Added lines #L145 - L147 were not covered by tests

Check warning on line 167 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L160-L167

Added lines #L160 - L167 were not covered by tests

Check warning on line 178 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L177-L178

Added lines #L177 - L178 were not covered by tests

Check warning on line 234 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L234

Added line #L234 was not covered by tests

Check warning on line 241 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L236-L241

Added lines #L236 - L241 were not covered by tests

Check warning on line 247 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L247

Added line #L247 was not covered by tests

Check warning on line 273 in src/core/config/remote/remote_config_manager.ts

codecov / codecov/patch

src/core/config/remote/remote_config_manager.ts#L272-L273

Added lines #L272 - L273 were not covered by tests

Check warning on line 43 in src/core/config/remote/remote_config_tasks.ts

codecov / codecov/patch

src/core/config/remote/remote_config_tasks.ts#L38-L43

Added lines #L38 - L43 were not covered by tests

Check warning on line 32 in src/core/error_messages.ts

codecov / codecov/patch

src/core/error_messages.ts#L32

Added line #L32 was not covered by tests

Check warning on line 1210 in src/core/k8.ts

codecov / codecov/patch

src/core/k8.ts#L1209-L1210

Added lines #L1209 - L1210 were not covered by tests

Check warning on line 1212 in src/core/k8.ts

codecov / codecov/patch

src/core/k8.ts#L1212

Added line #L1212 was not covered by tests

Check warning on line 1384 in src/core/k8.ts

codecov / codecov/patch

src/core/k8.ts#L1384

Added line #L1384 was not covered by tests

Check warning on line 1397 in src/core/k8.ts

codecov / codecov/patch

src/core/k8.ts#L1397

Added line #L1397 was not covered by tests

Check warning on line 1738 in src/core/k8.ts

codecov / codecov/patch

src/core/k8.ts#L1733-L1738

Added lines #L1733 - L1738 were not covered by tests

View more details on Codecov