Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix: undefined when calling or querying a contract #271

Merged

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Aug 17, 2022

Signed-off-by: georgi-l95 glazarov95@gmail.com

Description:

  • Hedera SDK is using @hashgraph/proto version 2.9.0, but hethers.js was using the old one 2.1.5. In the new version some exports are changed, therefore when used in one project a conflict occur, where it can't find the right modules. Updating version and modifying the exports, fixes this.

  • Updated images of the node to the latest in tests.

  • Changed to using hedera-local with tag v.1.1.0 when running tests, because otherwise of the latest changes in hedera-local-node repo, it's unable to start the node.

Related issue(s):

Fixes #270

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 self-assigned this Aug 17, 2022
@georgi-l95 georgi-l95 changed the title chore: bump proto version to 2.9.0 fix: undefined when calling or querying a contract Aug 17, 2022
@georgi-l95 georgi-l95 force-pushed the 270-running-hethers-v114-with-js-sdk-2171-results-in-errors branch from 6f77ddc to 1d1b198 Compare August 19, 2022 09:28
@georgi-l95 georgi-l95 marked this pull request as ready for review August 19, 2022 09:49
Copy link
Collaborator

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@georgi-l95 georgi-l95 merged commit b83f5f2 into master Aug 19, 2022
@georgi-l95 georgi-l95 deleted the 270-running-hethers-v114-with-js-sdk-2171-results-in-errors branch August 19, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running hethers v1.1.4 with js sdk 2.17.1 (same project) results in errors
2 participants