This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add axios retry interceptor #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgi-l95
requested review from
ar-conmit,
Daniel-K-Ivanov,
Ivo-Yankov and
natanasow
ar-conmit
reviewed
Aug 15, 2022
Ivo-Yankov
reviewed
Aug 15, 2022
Signed-off-by: georgi-l95 <glazarov95@gmail.com> test for options extended Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix Signed-off-by: georgi-l95 <glazarov95@gmail.com> resolve comments Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
force-pushed
the
265-add-retry-logic-to-mirror-node-requests
branch
from
8cd6895 to
1a87125
Compare
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
natanasow
approved these changes
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: georgi-l95 glazarov95@gmail.com
Description:
Add an axios retry interceptor that will retry failures that aren't a result of user input. Default values for retries, which can be customised. Exponential back-off
Related issue(s):
Fixes #265
Notes for reviewer:
Extended some of the tests to fit this new functionality. Others which test for bad requests cover this already.
Checklist