Fix: Contract function parameters #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamzedev
force-pushed
the
fix/smart-contract-int-calls
branch
3 times, most recently
from
c62d75c
to
408a595
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #767 +/- ##
===========================================
+ Coverage 57.78% 61.17% +3.38%
===========================================
Files 163 163
Lines 32892 33624 +732
===========================================
+ Hits 19007 20568 +1561
+ Misses 12601 11764 -837
- Partials 1284 1292 +8
☔ View full report in Codecov by Sentry. |
rokn
reviewed
Jul 16, 2023
bamzedev
force-pushed
the
fix/smart-contract-int-calls
branch
from
fac2cc2
to
aaa9863
Compare
rokn
approved these changes
Jul 18, 2023
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
bamzedev
force-pushed
the
fix/smart-contract-int-calls
branch
from
67bd625
to
35da5de
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the issues that the SDK have with different types when interacting with smart contracts.
It has breaking changes as some functions are now returning different types, i.e. instead of uint now return int.
Maybe we need to create a new "wrapper" functions for the uint/int types as the current solution is very hard for the users to deal with.
Related issue(s):
Fixes #764, #769, #701
Notes for reviewer:
Currently some tests fail due to parallel execution. Will work on that.
Checklist