Fixed network increase backoff concurrency issue #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #765 +/- ##
===========================================
- Coverage 57.87% 57.78% -0.09%
===========================================
Files 162 163 +1
Lines 32601 32892 +291
===========================================
+ Hits 18868 19007 +139
- Misses 12451 12601 +150
- Partials 1282 1284 +2
☔ View full report in Codecov by Sentry. |
rokn
force-pushed
the
fix/increase-backoff-concurrency
branch
2 times, most recently
from
6317ffa
to
8866970
Compare
|
suggestion: add |
rokn
force-pushed
the
fix/increase-backoff-concurrency
branch
from
8866970
to
e68e189
Compare
Signed-off-by: Antonio Mindov <antonio.mindov@limechain.tech>
rokn
force-pushed
the
fix/increase-backoff-concurrency
branch
from
e68e189
to
053c805
Compare
Signed-off-by: Antonio Mindov <antonio.mindov@limechain.tech>
rokn
force-pushed
the
fix/increase-backoff-concurrency
branch
from
aadc9a2
to
3754732
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bamzedev
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes some concurrency issues with the Network instances, related to accessing
healthyNodes. It's protecting only the part of the instance which is used when executing transactions.Related issue(s):
Fixes #762
Fixes #761
Checklist