Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-submit transaction in case of throttle at receipt #1072

Merged
merged 16 commits into from
Sep 25, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Sep 18, 2024

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Sep 18, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 57.81250% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.54%. Comparing base (616a07f) to head (2e105bd).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
transaction.go 16.66% 20 Missing ⚠️
transaction_record_query.go 78.57% 3 Missing ⚠️
transaction_receipt_query.go 81.81% 2 Missing ⚠️
transaction_response.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   73.64%   73.54%   -0.10%     
==========================================
  Files         171      176       +5     
  Lines       24299    25094     +795     
==========================================
+ Hits        17894    18456     +562     
- Misses       5688     5893     +205     
- Partials      717      745      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov changed the title chore: Revert retry logic fix: Re-submit transaction in case of throttle at receipt Sep 24, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
utilities_for_test.go Outdated Show resolved Hide resolved
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov marked this pull request as ready for review September 25, 2024 07:24
@0xivanov 0xivanov requested review from a team as code owners September 25, 2024 07:24
transaction_response.go Outdated Show resolved Hide resolved
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But could be reverted if Hedera services eliminates problems related to throttle.

@0xivanov 0xivanov merged commit 6eb526f into main Sep 25, 2024
11 of 13 checks passed
@0xivanov 0xivanov deleted the fix-record-and-receipt-retry branch September 25, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants