Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serve latest commit version #988

Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: serve latest commit version #988

merged 1 commit into from
Jan 3, 2025

Conversation

ofirc77
Copy link
Collaborator

@ofirc77 ofirc77 commented Dec 23, 2024

Add a simple fix for the version hash bug - #917
Please advise how you think this tag should be look on the about page.

@ofirc77 ofirc77 requested a review from NoamGaash as a code owner December 23, 2024 17:48
@ofirc77 ofirc77 self-assigned this Dec 23, 2024
Comment on lines 32 to 34
run: echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
- name: Generate Version File
run: echo "export const COMMIT_HASH = '${{ env.COMMIT_HASH }}';" > src/version.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it be easier to do something like this?

Suggested change
run: echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
- name: Generate Version File
run: echo "export const COMMIT_HASH = '${{ env.COMMIT_HASH }}';" > src/version.js
run: echo "$(git rev-parse --short HEAD)" >> public/hash.txt

@ofirc77 ofirc77 changed the title Fix: add versioning or latest commit information to our about page fix: add versioning or latest commit information to our about page Dec 31, 2024
@ofirc77 ofirc77 force-pushed the add_commit_hash branch 5 times, most recently from 3be64ec to 1c33880 Compare December 31, 2024 18:46
@NoamGaash
Copy link
Member

I can't see it in the dist-build artifact from the build job, maybe it should be added in a later step

@ofirc77 ofirc77 closed this Jan 2, 2025
@ofirc77
Copy link
Collaborator Author

ofirc77 commented Jan 2, 2025

Done

@ofirc77 ofirc77 reopened this Jan 2, 2025
@NoamGaash NoamGaash changed the title fix: add versioning or latest commit information to our about page feat: serve latest commit version Jan 3, 2025
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@NoamGaash
Copy link
Member

Merging because I can't wait to see it live.

@NoamGaash NoamGaash merged commit 75338ac into main Jan 3, 2025
28 of 30 checks passed
@NoamGaash NoamGaash deleted the add_commit_hash branch January 3, 2025 11:51
@NoamGaash
Copy link
Member

I would expect that https://open-bus-map-search.hasadna.org.il/hash.txt will serve the file by now
maybe we do have a problem with the deployment

@NoamGaash
Copy link
Member

It's not a deployment problem - the change made in #992 is reflected in production

@ofirc77
Copy link
Collaborator Author

ofirc77 commented Jan 6, 2025

Hi @NoamGaash, please explain your insights and I will try to debug

@NoamGaash
Copy link
Member

@ofirc77 when navigating to https://open-bus-map-search.hasadna.org.il/hash.txt we don't see the hash file

did you try to build and execute the docker image?

@ofirc77
Copy link
Collaborator Author

ofirc77 commented Jan 7, 2025

@NoamGaash I don't think so. can you please explain how to do it?
I checked it via the CI process in the commit

I opened another commit for this fix - https://github.com/hasadna/open-bus-map-search/pull/1001/checks
We can talk there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants