-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serve latest commit version #988
Conversation
.github/workflows/build.yml
Outdated
run: echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV | ||
- name: Generate Version File | ||
run: echo "export const COMMIT_HASH = '${{ env.COMMIT_HASH }}';" > src/version.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't it be easier to do something like this?
run: echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV | |
- name: Generate Version File | |
run: echo "export const COMMIT_HASH = '${{ env.COMMIT_HASH }}';" > src/version.js | |
run: echo "$(git rev-parse --short HEAD)" >> public/hash.txt |
d692121
to
6716647
Compare
3be64ec
to
1c33880
Compare
I can't see it in the dist-build artifact from the build job, maybe it should be added in a later step |
1c33880
to
e8f46bd
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Merging because I can't wait to see it live. |
I would expect that https://open-bus-map-search.hasadna.org.il/hash.txt will serve the file by now |
It's not a deployment problem - the change made in #992 is reflected in production |
Hi @NoamGaash, please explain your insights and I will try to debug |
@ofirc77 when navigating to https://open-bus-map-search.hasadna.org.il/hash.txt we don't see the hash file did you try to build and execute the docker image? |
@NoamGaash I don't think so. can you please explain how to do it? I opened another commit for this fix - https://github.com/hasadna/open-bus-map-search/pull/1001/checks |
Add a simple fix for the version hash bug - #917
Please advise how you think this tag should be look on the about page.