-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix storage class page broken if get unknown provisioner #1227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
…v1.4/pr-1227 fix storage class page broken if get unknown provisioner (backport #1227)
I know I'm late with the review on this (sorry!) but it might be worth falling back to showing |
...yeah this seems to work: --- a/pkg/harvester/models/harvester/storage.k8s.io.storageclass.js
+++ b/pkg/harvester/models/harvester/storage.k8s.io.storageclass.js
@@ -55,7 +55,7 @@ export default class HciStorageClass extends StorageClass {
key = `harvester.storage.storageClass.lvm.label`;
}
- return key ? this.$rootGetters['i18n/t'](key) : null;
+ return key ? this.$rootGetters['i18n/t'](key) : this.provisioner;
}
get isLonghornV2() { This matches what you see if you click the storage class to view the details: |
Summary
freenas-iscsi-csi
provisoner is unknown which is not Longhorn v1, Longhornv2 or LVM.We can show empty string for unknown provisoner
PR Checklist
Related Issue #
harvester/harvester#6970
Screenshot/Video