-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Rancher schemaDefinitions #1208
Conversation
c251ea9
to
66a5f1f
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
66a5f1f
to
df17887
Compare
Verified this PR fixed harvester/harvester#6846 and harvester/harvester#6825 issues. ![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this PR against
- Rancher 2.8.5 ✅
- Rancher 2.9.2 ✅
- harvester standalone ✅
Screen.Recording.2024-10-30.at.10.30.43.AM.mov
The harvester/harvester#6846 and harvester/harvester#6825 issues are fixed and do sanity check on vm image creation, vm creation, volume attach doesn't see big issue.
But since there are lots of shell (core library) code change (cf1caaa), I can't guarantee there is no bug after PR merged.
But we can take look at any occurred bugs ASAP.
@mergify backport release-harvester-v1.4 |
✅ Backports have been created
|
…v1.4/pr-1208 Handle Rancher schemaDefinitions (backport #1208)
Summary
PR Checklist
Related issue harvester/harvester#6846
Related issue harvester/harvester#6825
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video