Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Rancher schemaDefinitions #1208

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Oct 21, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related issue harvester/harvester#6846
Related issue harvester/harvester#6825

Occurred changes and/or fixed issues

Technical notes summary

  • It adds the schemaDefinition handling (porting from Rancher)
  • It removes Cypress tests which were inherited from Rancher code base
  • Fixing the Output buffer edit yaml view

Areas or cases that should be tested

  • Yaml Views - Yaml files should be consistent and well formatted
  • Standalone & Embedded mode

Areas which could experience regressions

Screenshot/Video

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf changed the title Schema diet & Output fix Handle Rancher schemaDefinitions Oct 22, 2024
@torchiaf torchiaf marked this pull request as ready for review October 22, 2024 16:16
@a110605
Copy link
Collaborator

a110605 commented Oct 23, 2024

Verified this PR fixed harvester/harvester#6846 and harvester/harvester#6825 issues.

Screenshot 2024-10-23 at 3 15 02 PM Screenshot 2024-10-23 at 3 19 01 PM

Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR against

  • Rancher 2.8.5 ✅
  • Rancher 2.9.2 ✅
  • harvester standalone ✅
Screen.Recording.2024-10-30.at.10.30.43.AM.mov

The harvester/harvester#6846 and harvester/harvester#6825 issues are fixed and do sanity check on vm image creation, vm creation, volume attach doesn't see big issue.

But since there are lots of shell (core library) code change (cf1caaa), I can't guarantee there is no bug after PR merged.
But we can take look at any occurred bugs ASAP.

@torchiaf torchiaf merged commit 025eaea into harvester:master Oct 31, 2024
9 checks passed
@torchiaf
Copy link
Collaborator Author

@mergify backport release-harvester-v1.4

Copy link

mergify bot commented Oct 31, 2024

backport release-harvester-v1.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants