Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root disk volume accessMode should be RWX #1200

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Root disk volume accessMode should be RWX #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pkg/harvester/mixins/harvester-vm/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { HCI as HCI_ANNOTATIONS } from '@pkg/harvester/config/labels-annotations
import impl, { QGA_JSON, USB_TABLET } from './impl';
import { uniq } from '@shell/utils/array';
import { parseVolumeClaimTemplates } from '../../utils/vm';
import { LONGHORN_VERSION_V1, LONGHORN_VERSION_V2 } from '@shell/models/persistentvolume';

const LONGHORN_V2_DATA_ENGINE = 'longhorn-system/v2-data-engine';

Expand Down Expand Up @@ -258,12 +257,6 @@ export default {
}
},

longhornSystemVersion() {
const v2DataEngine = this.$store.getters[`${ this.inStore }/byId`](LONGHORN.SETTINGS, LONGHORN_V2_DATA_ENGINE) || {};

return v2DataEngine.value === 'true' ? LONGHORN_VERSION_V2 : LONGHORN_VERSION_V1;
},

customVolumeMode() {
return this.storageClassSetting.volumeMode || 'Block';
},
Expand Down Expand Up @@ -455,7 +448,7 @@ export default {
id: randomStr(5),
source: SOURCE_TYPE.IMAGE,
name: 'disk-0',
accessMode: this.longhornSystemVersion === LONGHORN_VERSION_V2 ? 'ReadWriteOnce' : 'ReadWriteMany',
accessMode: 'ReadWriteMany', // root disk only support LHv1 volume, should be RWX
bus,
volumeName: '',
size,
Expand Down
Loading