Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace check when finding volume attachVM #1136

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add namespace check when finding volume attachVM #1136

merged 1 commit into from
Sep 10, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 10, 2024 •
edited
Loading

Summary

Add namespace check when find volume attachVM.
Related to previous merged PR : #1065

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6528

Areas which could experience regressions

Screenshot/Video

Screenshot 2024-09-10 at 11 35 24 AM

@a110605 a110605 added the Bug Fix Something isn't working label Sep 10, 2024
@a110605 a110605 requested review from bk201 and torchiaf September 10, 2024 04:08
@a110605 a110605 self-assigned this Sep 10, 2024
@a110605 a110605 changed the title Add namespace check when find volume attachVM Add namespace check when finding volume attachVM Sep 10, 2024
torchiaf
torchiaf approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 871c771 into harvester:master Sep 10, 2024
7 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Sep 10, 2024

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Sep 10, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk201 bk201 bk201 approved these changes

@torchiaf torchiaf torchiaf approved these changes

Assignees

@a110605 a110605

Labels
Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @bk201 @torchiaf