Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message upon each retry failure (backport #973) #1118

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 28, 2024

Summary

this is part of harvester/harvester#5288, after harvester/harvester#5386 merged to master, error message updated upon each retry failure. Before this pr, error message pops up only when upgrad CR imageReady is False.

Occurred changes and/or fixed issues

related to harvester/harvester#5288
harvester/harvester#6435

Technical notes summary

N/A

Areas or cases that should be tested

Harvester upgrade

Areas which could experience regressions

N/A

Screenshot/Video

Test upgrade

Screenshot from 2024-03-18 17-14-14

Screencast.from.2024-03-18.17-17-20.webm

Test Image
Screenshot from 2024-03-20 14-08-31

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

This is an automatic backport of pull request #973 done by [Mergify](https://mergify.com).

show vm image retry failure message in vmimage and upgrade cr

(cherry picked from commit b21b351)
@mergify mergify bot mentioned this pull request Aug 28, 2024
7 tasks
@brandboat
Copy link
Member

Please don't merge this pr until 1.3.2 cut out. This pr target to 1.3.3 release

@a110605 a110605 added Backport to v1.3 Backport PR target v1.3 DO NOT MERGED labels Aug 28, 2024
@a110605
Copy link
Collaborator

a110605 commented Sep 10, 2024

v1.3.2 is released. We can merge this PR to v1.3 branch.

@brandboat brandboat merged commit b58ee99 into release-harvester-v1.3 Sep 10, 2024
6 checks passed
@brandboat brandboat deleted the mergify/bp/release-harvester-v1.3/pr-973 branch September 10, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.3 Backport PR target v1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants