Show error message upon each retry failure (backport #973) #1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this is part of harvester/harvester#5288, after harvester/harvester#5386 merged to master, error message updated upon each retry failure. Before this pr, error message pops up only when upgrad CR imageReady is
False
.Occurred changes and/or fixed issues
related to harvester/harvester#5288
harvester/harvester#6435
Technical notes summary
N/A
Areas or cases that should be tested
Harvester upgrade
Areas which could experience regressions
N/A
Screenshot/Video
Test upgrade
Screencast.from.2024-03-18.17-17-20.webm
Test Image
![Screenshot from 2024-03-20 14-08-31](https://private-user-images.githubusercontent.com/4344302/314394393-35476c38-3b21-4b4a-b144-5e5c29f4f983.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTY2NjcsIm5iZiI6MTczOTI1NjM2NywicGF0aCI6Ii80MzQ0MzAyLzMxNDM5NDM5My0zNTQ3NmMzOC0zYjIxLTRiNGEtYjE0NC01ZTVjMjlmNGY5ODMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDY0NjA3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWVmMTg5MTg5NzhlNzA5NTE2NzNmYWJmZjY1ZTNjNzFjZmE5MTNhNTA4MDU1MThkYTdmMzhlMDZhOTUzNzkzYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.cH1e7sETmalrPPUbAwMafqGpQiBMvvmTH7B9EvSpK3U)
Checklist
This is an automatic backport of pull request #973 done by [Mergify](https://mergify.com).