Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: honor annotation matchNodes from network config to show selected nodes in detail page (backport #1083) #1091

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 5, 2024

Summary

Per discussion this comment with team, we decide to filter out witness node from backend annotation when creating network config via select all nodes.

Frontend only honors annoation network.harvesterhci.io/matched-nodes to show selected nodes in page.

Note. we will have backend PR to filter out witness node in annotaton.network.harvesterhci.io/matched-nodes.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Note. this PR needs backport to v1.3.1 and v1.4

Related Issue #
harvester/harvester#5325

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Screenshot_20240726_123218


This is an automatic backport of pull request #1083 done by [Mergify](https://mergify.com).

Signed-off-by: a110605 <andy.lee@suse.com>
(cherry picked from commit 3c11f43)
@a110605 a110605 merged commit fe935d2 into release-harvester-v1.3 Aug 6, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.3/pr-1083 branch August 6, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants