fix: honor annotation matchNodes from network config to show selected nodes in detail page (backport #1083) #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per discussion this comment with team, we decide to filter out witness node from backend annotation when creating network config via
select all nodes
.Frontend only honors annoation
network.harvesterhci.io/matched-nodes
to show selected nodes in page.Note. we will have backend PR to filter out witness node in
annotaton.network.harvesterhci.io/matched-nodes
.PR Checklist
Note. this PR needs backport to v1.3.1 and v1.4
Related Issue #
harvester/harvester#5325
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
This is an automatic backport of pull request #1083 done by [Mergify](https://mergify.com).