Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Upgrade button when upgrade is in progress #1081

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

torchiaf
Copy link
Collaborator

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue harvester/harvester#6144

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@a110605
Copy link
Collaborator

a110605 commented Jul 26, 2024

Logic changed is good, let me setup the harvester v1.2.1 to test the upgrade flow.

@a110605
Copy link
Collaborator

a110605 commented Jul 26, 2024

I was unable to upgrade from v1.2.1 to v1.2.2 in local env. The upgrade process stucks more than 1 hour...
But the yellow upgrade is hidden while isUpgradeInProgress=true.

Screenshot_20240726_215137

I will let QA verify the upgrading flow.

@torchiaf torchiaf merged commit d1254dc into harvester:master Jul 29, 2024
7 checks passed
@torchiaf
Copy link
Collaborator Author

@mergify backport release-harvester-v1.2 release-harvester-v1.3

Copy link

mergify bot commented Jul 29, 2024

backport release-harvester-v1.2 release-harvester-v1.3

✅ Backports have been created

@torchiaf
Copy link
Collaborator Author

@mergify backport release-harvester-v1.4

Copy link

mergify bot commented Jul 29, 2024

backport release-harvester-v1.4

✅ Backports have been created

torchiaf added a commit that referenced this pull request Jul 30, 2024
…v1.2/pr-1081

Hide Upgrade button when upgrade is in progress (backport #1081)
torchiaf added a commit that referenced this pull request Jul 30, 2024
…v1.3/pr-1081

Hide Upgrade button when upgrade is in progress (backport #1081)
torchiaf added a commit that referenced this pull request Jul 30, 2024
…v1.4/pr-1081

Hide Upgrade button when upgrade is in progress (backport #1081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants