Hide restore column when completed #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
force-pushed
the
6195-hide-restore-column
branch
from
c3cd87d to
d0c43eb
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
6195-hide-restore-column
branch
from
d0c43eb to
dde7421
Compare
a110605
reviewed
Jul 23, 2024
| @@ -647,6 +647,10 @@ export default class VirtVm extends HarvesterResource { | |||
| return null; | |||
| } | |||
|
|
|||
| get isTerminating() { | |||
| return this?.metadata?.deletionTimestamp; | |||
There was a problem hiding this comment.
deletionTimestamp is string?
nit: better convert to boolean
return !!this?.metadata?.deletionTimestamp;
a110605
approved these changes
Jul 23, 2024
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
|
@mergify backport release-harvester-v1.3 release-harvester-v1.4 |
✅ Backports have been created
|
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Checklist
Related Issue harvester/harvester#6195
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video