UI: allow all URL schemas for custom console URLs (backport #1059) #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Allow all URL schemas for custom console URLs. This change removes a check that enforces the 'Console' button of a Harvester node to only redirect to URLs starting with `http://` or `https://`. Otherwise it will prepend `http://` to the configured URL. This breaks non-HTTP URL schemas like `vnc://` or `rtsx://`, which are sometimes used to launch custom VNC viewers instead of using the built-in one. fixes: harvester/harvester#6042 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com> (cherry picked from commit 84e88c8)
Ensure the console URL is configured with a schema matching the regular expression `^[a-z]+:\/\/`. Otherwise disable the console button. This allows all sorts of URL schemas, even non-standard ones, but also ensures that a sane URL is entered. Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com> (cherry picked from commit 5b89aca)
Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com> (cherry picked from commit 0a9a892)
a110605
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow all URL schemas for custom console URLs. This change removes a check that enforces the 'Console' button of a Harvester node to only redirect to URLs starting with
http://orhttps://. Otherwise it will prependhttp://to the configured URL. This breaks non-HTTP URL schemas likevnc://orrtsx://, which are sometimes used to launch custom VNC viewers instead of using the built-in one.fixes: harvester/harvester#6042
Summary
PR Checklist
Related Issue #
harvester/harvester#6042
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
This is an automatic backport of pull request #1059 done by [Mergify](https://mergify.com).