Update bevy to 0.12.0 and update breaking changes #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harudagondi
reviewed
Nov 29, 2023
src/lib.rs
Outdated
| /// .run() | ||
| /// ``` | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Why exactly is this lint here? Just asking.
There was a problem hiding this comment.
I think sample_rate only gets set via the tests.
without this Rust reports,
warning: field `sample_rate` is never read
--> src/lib.rs:56:5
|
55 | pub struct DspPlugin {
| --------- field in this struct
56 | sample_rate: f32,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Let me know if there is another or better way to resolve this warning.
src/lib.rs
Outdated
| @@ -88,8 +87,8 @@ impl Default for DspPlugin { | |||
|
|
|||
| impl Plugin for DspPlugin { | |||
| fn build(&self, app: &mut App) { | |||
| app.insert_resource(DspManager::new(self.sample_rate)) | |||
| .add_asset::<DspSource>(); | |||
| app.init_resource::<DspManager>() | |||
There was a problem hiding this comment.
Why is init_resource used instead of insert_resource?
There was a problem hiding this comment.
Thanks for catching this ❤️. I thought insert_resource was deprecated, but only add_asset was. This also works with insert_resource so I will switch it back.
HParker
force-pushed
the
update-for-bevy-0.12.0
branch
from
ef4ce3a to
cdf81a3
Compare
|
I updated Kira as well since it already supports Bevy 0.12.0. Looks like oddio might need a patch to support bevy 0.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey thanks for the great project!
I want to try it out and I started with Bevy 0.12.0, so I took the liberty of updating this library to use bevy 0.12.0 and updated the incompatible APIs.