Use div macros for header/footer inclusion #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this changeset I removed <div> from allowed tags as it makes it possible to post arbitrary <div> tags in journals with @<div>@ markup. It was originally put there to avoid issue with <p> tag wrapping of included header/footer blocks by macros. I found a workaround in current Textile parser which allows to disable wrapping of macros. This can be done by adding "<code></code>" in the beginning of the line. This way the rest of the line is rendered as is without being put in a paragraph. This behavior may change in RedCloth4, but Redmine is still not there so we can use this workaround for a while, before Redmine comes up with an appropriate way to disable paragraphs. fixes haru#8 related https://code.google.com/archive/p/redminewikiext/issues/4 related https://redmine.org/issues/29588 related https://redmine.org/issues/13695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this changeset I removed
<div>from allowed tags as it makes itpossible to post arbitrary
<div>tags in journals with@<div>@markup.It was originally put there to avoid issue with
<p>tag wrapping ofincluded header/footer blocks by macros.
I found a workaround in current Textile parser which allows to disable
wrapping of macros. This can be done by adding
<code></code>in thebeginning of the line. This way the rest of the line is rendered as is
without being put in a paragraph.
This behavior may change in RedCloth4, but Redmine is still not there so
we can use this workaround for a while, before Redmine comes up with an
appropriate way to disable paragraphs.
fixes #8
related https://code.google.com/archive/p/redminewikiext/issues/4
related https://redmine.org/issues/29588
related https://redmine.org/issues/13695