Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where nested property is not supported #178

Closed
maharrabi opened this issue Dec 5, 2019 · 1 comment
Closed

Where nested property is not supported #178

maharrabi opened this issue Dec 5, 2019 · 1 comment
Labels
bug

Comments

@maharrabi
Copy link

The where filter as sort & map for ex, dont support nested property filter
ex: {% assign variable = authors | where: 'books.year', 2019 %}
@harttle harttle added the bug label Dec 6, 2019
harttle added a commit that referenced this issue Dec 12, 2019
@harttle
feat: nested property for the where filter, #178
60ec74f
harttle pushed a commit that referenced this issue Dec 12, 2019
@semantic-release-bot
chore(release): 9.5.0 [skip ci]
90d78ae 
# [9.5.0](v9.4.2...v9.5.0) (2019-12-12)

### Features

* nested property for the `where` filter, [#178](#178) ([60ec74f](60ec74f))
@harttle
Copy link
Owner

harttle commented Dec 14, 2019 •
edited
Loading

Supported on @9.5.0 You can find a test case here: 60ec74f#diff-513ba559a0340b55020e8432e057659aR172-R188

I'm not sure whether we should filter nested array properties (where authors.books are arrays). I even can't see a recursive structure in shopify/liquid implementation. If you can find a specific documentation on it, feel free to reopen this issue.

@harttle harttle closed this as completed Dec 14, 2019
@pdehaan pdehaan mentioned this issue Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harttle @maharrabi