Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PL-31591]: Increased ng-manager memory by 64MB #76

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

VikasMaddukuriHarness
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Ompragash Ompragash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VikasMaddukuriHarness Can you reflect this change on README (requirements section) as needed?

Also, this change is only for the Docker installer and not the helm installer? Ref

@VikasMaddukuriHarness VikasMaddukuriHarness requested a review from a team as a code owner March 23, 2023 10:42
@VikasMaddukuriHarness
Copy link
Contributor Author

Done @Ompragash. Thanks for noticing. Modified resource limits for helm installation as well.

@rkapoor10
Copy link
Contributor

rkapoor10 commented Mar 23, 2023

Successful pipeline run after modification.

Installation : using Docker compose and Helm Chart
Piepeline : sample deployment

Delegate installation [ using Minikube ]

  • if done using 4gb Memory and 4CPUs there are some intermediate issues like timeout, but pipeline run is successful
  • for 6gb Memory and 6CPUs the pipeline run is successful without any exceptions/timeout

Screenshot of successful run :

Docker-compose
Screenshot 2023-03-23 at 2 40 34 PM

Helm
Screenshot 2023-03-24 at 7 14 36 PM

Copy link
Collaborator

@Ompragash Ompragash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR @VikasMaddukuriHarness

@Ompragash Ompragash merged commit 6460508 into harness:main Mar 23, 2023
@sean-harness
Copy link
Collaborator

Does this fix the CrashLoopBackOff users have been reporting?

@harnesspravin
Copy link
Contributor

If CrashLoopBackOff is due to ng-manager memory constraints, then it should solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants