Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to turn on/off the negation behaviour #59

Closed
woodthom2 opened this issue Oct 29, 2024 · 0 comments
Closed

Allow user to turn on/off the negation behaviour #59

woodthom2 opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@woodthom2
Copy link
Contributor

woodthom2 commented Oct 29, 2024

Description

Question negation is language specific but not always wanted. Can we enable/disable it at the match_instruments function?

To clarify, there are some rule based scripts here which turn "I like" into "I don't like" etc in English and a few other languages. This is hard coded and some users want to be able to turn it off. Can you add a switch at library level and also at API level which stops the functions in negator.py being called?

Once we have enabled this switch we need to expose it as an option in the API. I have a related issue in the API issue tracker covering this function on the API side. However, the first step is to implement this switch in the Python library

Rationale

Sometimes users only want the absolute value of cosine similarity

See related R issue harmonydata/harmony_r#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant