Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] upgrade to 1.16 #3693

Merged
merged 6 commits into from
May 6, 2021
Merged

Conversation

AlexiaChen
Copy link
Contributor

@AlexiaChen AlexiaChen commented May 6, 2021

Issue

#3563

Test

  • test locally(just simply run make debug and use cli to check some information if it work)
  • [Regression test] test on explorer node mode without GODEBUG=madvdontneed=1 to check runtime if it Immediately return memory back to system
  • test locallnet Daniel mentioned https://github.com/harmony-one/harmony-test

@AlexiaChen AlexiaChen added the enhancement New feature or request label May 6, 2021
@AlexiaChen AlexiaChen requested review from LeoHChen, rlan35 and JackyWYX May 6, 2021 00:14
@rlan35
Copy link
Contributor

rlan35 commented May 6, 2021

please fix travis failure.

@AlexiaChen
Copy link
Contributor Author

please fix travis failure.

Yes. I created PR, I fixed one failure before, and the rest of failures, I am trying to fix , but it's a little strange.

@rlan35 rlan35 merged commit d4f48df into harmony-one:main May 6, 2021
@AlexiaChen AlexiaChen deleted the upgrade-go-version branch May 7, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants