Update installer path - part 2 (improve hariktgh-4) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [composer/composer](https://github.com/composer/composer) from 1.0.3 to 1.10.23. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@1.0.3...1.10.23) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
…poser-1.10.23 Bump composer/composer from 1.0.3 to 1.10.23
Bumps [composer/composer](https://github.com/composer/composer) from 2.0.0 to 2.1.9. - [Release notes](https://github.com/composer/composer/releases) - [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md) - [Commits](composer/composer@2.0.0...2.1.9) --- updated-dependencies: - dependency-name: composer/composer dependency-type: direct:development ...
…b/develop' into 2-composer2-support
- re-add check for installed file that was removed in hariktgh-4 (because `is_dir()` does not work there) - remove check for composer.json with check for valid module-file according https://github.com/processwire/processwire/blob/d78276e2c265f6b70384a13eb4febd4811a1db77/wire/core/Modules.php#L1178
|
@harikt can you accept this, or tell me what I should change that you can accept it? |
harikt
reviewed
Jun 30, 2022
What comments should I change? I am not realy sure what you mean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the check for a successful install like diskussed in harikt#4 (comment).
Additional it fixes as minor issue with dev-depencies to calm dependabot (details in 277d099 and b27babc).
I recommend creating a versions-tag for 1.1.1 after merging this.