Skip to content

Commit

Permalink
vfio/pci: fix potential memory leak in vfio_intx_enable()
Browse files Browse the repository at this point in the history
If vfio_irq_ctx_alloc() failed will lead to 'name' memory leak.

Fixes: 18c198c ("vfio/pci: Create persistent INTx handler")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lore.kernel.org/r/20240415015029.3699844-1-yebin10@huawei.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
  • Loading branch information
Ye Bin authored and awilliam committed Apr 22, 2024
1 parent d530531 commit 82b951e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/vfio/pci/vfio_pci_intrs.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,10 @@ static int vfio_intx_enable(struct vfio_pci_core_device *vdev,
return -ENOMEM;

ctx = vfio_irq_ctx_alloc(vdev, 0);
if (!ctx)
if (!ctx) {
kfree(name);
return -ENOMEM;
}

ctx->name = name;
ctx->trigger = trigger;
Expand Down

0 comments on commit 82b951e

Please sign in to comment.